Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use last year's periods #3321

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore: use last year's periods #3321

wants to merge 4 commits into from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jan 2, 2025

Key features

  1. use last year's period wherever possible

Description

This is to avoid failing tests in the beginning of a new year when the new data is not added to the test DB yet.

@edoardo
chore: use last year's periods
f89ac7b 
This is to avoid failing tests in the beginning of a new year when the
new data is not added to the test DB yet.
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 2, 2025 •
edited
Loading

🚀 Deployed on https://pr-3321.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify January 2, 2025 14:34 Inactive
@edoardo
chore: use visualizations without this year period
546b487 
This is to avoid failing tests in the beginning of a new year when the
new data is not added to the test DB yet.
@dhis2-bot dhis2-bot temporarily deployed to netlify January 3, 2025 15:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 8, 2025 09:55 Inactive
@edoardo edoardo marked this pull request as draft January 8, 2025 14:55
@edoardo
Copy link
Member Author

edoardo commented Jan 8, 2025

I converted to Draft since I realised the data is not the same for all the years, so some tests now fail because they expect a different value.
It's easy to fix the tests where there is actual data for both the current and the last year, but in some cases there is only data for the current year, so for those we would have to add the data to the DB dump.

@dhis2-bot dhis2-bot temporarily deployed to netlify January 9, 2025 10:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferarnesen jenniferarnesen jenniferarnesen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edoardo @dhis2-bot @jenniferarnesen